Skip to content

Fix deletion of OD parameter #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sveinse merged 1 commit into from
Nov 5, 2025
Merged

Fix deletion of OD parameter #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/objdictgen/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,13 +931,13 @@ def UpdateMapVariable(self, index: int, subindex: int, size: int):

def RemoveLine(self, index: int, maxval: int, incr: int = 1):
""" Remove the given index and shift all the following indexes """
# FIXME: This function is called from NodeManager.RemoveCurrentVariable()
# but uncertain on how it is used.
i = index
while i < maxval and self.IsEntry(i + incr):
# FIXME: Not sure what this does
self.Dictionary[i] = self.Dictionary[i + incr]
i += incr
self.Dictionary.pop(i)
self.ParamsDictionary.pop(i, None)

def RemoveIndex(self, index: int|Iterable[int]) -> None:
""" Remove the given index or indexes """
Expand Down
Loading