fix: add null safety to FileDiff getBefore/getAfter#28
Open
yangyu0227 wants to merge 1 commit into
Open
Conversation
Root cause: SseEventListener's Gson instance does not register FileDiffDeserializer, so when the server sends SSE diff events with null 'before'/'after' values, Gson creates FileDiff instances with null fields (bypassing constructor via UnsafeAllocator). Fix: 1. Register FileDiffDeserializer in SseEventListener's Gson builder (prevents null fields at the source) 2. Add null-safe elvis operator in SessionManager.resolveBeforeContent (defense in depth)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: SseEventListener's Gson instance does not register FileDiffDeserializer, so when the server sends SSE diff events with null 'before'/'after' values, Gson creates FileDiff instances with null fields (bypassing constructor via UnsafeAllocator).
Fix: