feat(web): i18n follow-ups — intake-forms extraction + cross-island E2E - #2346
Merged
Conversation
Deploying breeze with
|
| Latest commit: |
f4c1bf9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02c2e8a4.breeze-9te.pages.dev |
| Branch Preview URL: | https://feat-web-i18n-followups.breeze-9te.pages.dev |
j5252
approved these changes
Jul 12, 2026
Post-#2340 follow-ups: - internationalize the ticket intake-forms surface that landed in English via #2339: TicketFormsCard (73 keys), CreateTicketPage form picker, TicketFormFields select placeholder — en + pt-BR, count forms for plurals, admin-authored field content left untranslated - add e2e-tests/tests/i18n-language-switch.spec.ts: pt-BR selection propagates across independent islands without reload, survives reload (hydration-deferred restore), reverts to en; verified green 3x against a live wt-stack; minimal data-testids added to ThemingSettings language options - fix docker/Dockerfile.api.dev: copy packages/extension-api so the dev API image builds again (broken since #2324 added the @breeze/extension-api workspace dep) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ToddHebebrand
force-pushed
the
feat/web-i18n-followups
branch
from
July 12, 2026 20:52
9de44e9 to
f4c1bf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the #2340 (pt-BR console i18n) review, now that it's merged.
What's here
1. Intake-forms surface internationalized. #2339 landed after the extraction waves, so its UI was hardcoded English. Converted
TicketFormsCard(73 new keys: scope fieldset, field editor, preview, validation messages, toasts, plural counts via_one/_other), the form picker inCreateTicketPage, andTicketFormFields' select placeholder — en + pt-BR at exact parity. Admin-authored field labels/help text are tenant data and stay untranslated. en values are byte-identical to the previous hardcoded strings, so #2339's existing tests pass unchanged (62/62).2. Cross-island language-switch E2E. New
e2e-tests/tests/i18n-language-switch.spec.ts+ Page Object: switches to pt-BR from Appearance settings and asserts two independent islands (settings content + header org-switcher) render Portuguese without a reload, that the locale survives a full reload (polling past the hydration-deferred restore), and that switching back to en works. All locators aredata-testid(minimal testids added to the ThemingSettings language options); text assertions use exact catalog strings. Verified green 3 consecutive runs against a live wt-stack.3. Dev API image build fix (drive-by, found while verifying).
docker/Dockerfile.api.devhas been broken on main since #2324 added the@breeze/extension-apiworkspace dep — the Dockerfile never copiedpackages/extension-api, sopnpm installfails withERR_PNPM_WORKSPACE_PKG_NOT_FOUNDand no dev stack can build from a fresh worktree. Two COPY lines fix it.Verification
<Trans>checks, localeParity, extractionQuality) + all touched component suites: 19 files / 242 tests greentsc --noEmitclean1 passedeach run)Not included (needs a human): native pt-BR review of the machine-drafted strings — mazarine offered on Discord.
🤖 Generated with Claude Code