code refector by Muhammad Imran #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPand4B
reviewed
Jul 30, 2021
| 'message'=>'Voting completed successfully' | ||
| 'status' => $status, | ||
| 'message' => $message | ||
| ]); |
| return $this->response(200, 'Voting completed successfully'); | ||
| } | ||
|
|
||
| public function response($status = 200, $message = '') |
There was a problem hiding this comment.
Optional parameters should be at the end. In this case 200 should be the default, so it would make more sense this way. And because the message should always be set you can remove the empty string as default :)
Suggested change
| public function response($status = 200, $message = '') | |
| public function response($message, $status = 200) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.