Refactor the code #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agus24
reviewed
Jul 30, 2021
Comment on lines
+1
to
+10
| <?php | ||
|
|
||
| namespace App\Http; | ||
|
|
||
| class Status | ||
| { | ||
| public const OK = 200; | ||
| public const ERROR = 500; | ||
| public const UPDATED = 201; | ||
| } |
There was a problem hiding this comment.
you dont need to create enum class. you can use Symfony\Component\HttpFoundation\Response
Response::HTTP_OK will return 200
Response::HTTP_CREATED will return 201
Response::HTTP_NOT_FOUND will return 404
Response::HTTP_INTERNAL_SERVER_ERROR will return 500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.