First attempt to improve the code #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2021 20:07
xmokko
reviewed
Jul 31, 2021
| $voice->update([ | ||
| 'value'=>$request->post('value') | ||
|
|
||
| private $user; |
There was a problem hiding this comment.
This value use only in one method, better make as local
|
|
||
| public function voice(Request $request) | ||
| { | ||
| $this->usre = Auth::user(); |
There was a problem hiding this comment.
Mistake "$this->usre"
better to use $userId = Auth::id();
| 'value' => 'required|boolean', | ||
| ]); | ||
|
|
||
| $question = Question::findOrfail($request->question_id); |
There was a problem hiding this comment.
This never fail, we already validate "exists:questions,id"
| ]); | ||
| } else if (($voice) && $voice->value !== $request->value) { | ||
| //update or create first param is the condition of match values, second indicate fields to be updated | ||
| $voice->updateOrCreate([ |
There was a problem hiding this comment.
$voice exists, we don't need create record
There was a problem hiding this comment.
with this parameters user will vote 2 times
| $question = Question::findOrfail($request->question_id); | ||
| if ($question->user_id == $this->user->id) | ||
| return response()->json([ | ||
| 'status' => 500, |
| ]); | ||
| } | ||
|
|
||
| return response()->json([ |
There was a problem hiding this comment.
Didn't check !$voice. If record didn't exist we can't vote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.