fix: improve marketing navigation and add go-to-top#119
Closed
LarytheLord wants to merge 1 commit intomainfrom
Closed
fix: improve marketing navigation and add go-to-top#119LarytheLord wants to merge 1 commit intomainfrom
LarytheLord wants to merge 1 commit intomainfrom
Conversation
Add a real Home link to the marketing navigation, make landing-page link highlighting respond to scroll position, and expose active link state through aria-current for better accessibility. Also mount the existing GoToTop control from the root layout and limit it to public marketing/legal pages so dashboard and auth screens keep their dedicated layouts uncluttered. Verified with npm run lint and npm run type-check.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Closing this PR because it was opened before the GitHub account switch. A replacement PR with the same change set is now open under the correct account here: #120. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up a pair of low-risk landing-page issues that still matched the current codebase after triaging the open issue list.
What changed
Homelink to the public marketing navigation/home#...links as active at oncearia-currentto active nav links for better accessibility semanticsGoToTopcontrol from the root layoutGoToTopbutton to public marketing/legal pages so dashboard and auth layouts stay unclutteredWhy this approach
The repo already had a
GoToTopcomponent, but it was never wired into the shared layout. The nav also had path-based active styling, but the public hash links all rendered as active whenever the user was on/home, which made section state unclear. This PR fixes both behaviors without touching auth, API, schema, or dashboard flows.Issue triage notes
While reviewing the current open issues, I found that
#91appears already addressed in the current branch state: both the login and register forms already use explicitLabelcomponents rather than placeholder-only inputs. I therefore started with the smaller unresolved UI items that still mapped cleanly to the codebase, especially the navigation behavior from#29and the floating back-to-top affordance from#21.Files changed
app/layout.tsxcomponents/Navigation.tsxcomponents/ui/go-to-top.tsxVerification
npm run lint? (existing repo warnings remain, no new lint errors introduced)npm run type-check?Follow-up candidates
The next good low-risk issue to tackle looks like
#77(section-number contrast/visibility), since it should be a contained landing-page styling fix without backend or schema work.