Conversation
|
@Monoartiam99 is attempting to deploy a commit to the larythelord's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@LarytheLord Please check it once. |
|
I like the low-risk intent around fixing broken footer assets, but I'd strongly consider separating the footer/UI repair from the dev-only PWA behavior change. On the current main-line code the public shell is already fairly centralized, so mixing app-shell/service-worker behavior into what started as a footer regression means reviewers have to re-evaluate unrelated startup semantics. A tiny asset/UI-only PR would likely merge faster, and the Windows-path |
|
I opened #121 as a smaller follow-up that fixes payment logos in the current shared |
|
Thanks for the effort here @Monoartiam99 — the footer payment icon fix you were aiming at is a real issue (now resolved by #121). However this PR can't be merged as-is because the architecture has changed significantly since it was opened: The main issue: The diff edits a 1000-line landing page component that no longer exists. import { redirect } from 'next/navigation';
export default function RootPage() { redirect('/home'); }The actual landing page lives at Other concerns:
The payment icon fix specifically (which is what #87 asked for) was picked up cleanly in #121 which is now merged. Closing this PR — but please do pick up another issue if you'd like to contribute! |
Summary
Added placeholder SVGs for payment icons (visa, mastercard, paypal) to
public/images/Updated
app/page.tsxto reference the placeholders and fixed malformed JSX that caused build errors.Temporarily disabled next-pwa in development to avoid SW build/parse errors on Windows paths.
Closes Improve the footer section #87
Verification:
npm run devstarts and reports PWA disabled in development.Notes:
🎯 Rationale
This PR fixes two issues causing the dev server to fail and the footer to display missing images:
Missing payment images in the footer caused 404s and broke the visual layout.
During development, next-pwa generated a service worker that failed to parse on Windows when the repository path contains special characters (an apostrophe). That, plus accidental malformed JSX that had been inserted into [page.tsx] caused parse/runtime errors (Unterminated regexp literal / Unexpected token) preventing the app from compiling.
📝 Summary of Changes:
Added placeholder SVGs for payment icons:
public/images/visa.svg
public/images/mastercard.svg
public/images/paypal.svg
Updated [page.tsx]:
Replaced references to missing PNGs with the new SVGs.
Removed stray/malformed JSX and fixed tag balance that caused parsing errors.
Updated [next.config.mjs]:
Configured next-pwa to disable service worker generation in development using [disable: process.env.NODE_ENV !== 'production'] (PWA remains enabled in production).
🔧 Technical Details
✅ Testing
Test Details
📚 Documentation
🔄 Breaking Changes
This PR does not introduce breaking changes. PWA behavior changes only in the dev environment (disabled) and remains active in production builds.
🎨 User-Facing Changes
Frontend Changes:
Footer icons updated (appear as placeholders).
No UX workflow changes.
Backend/API Changes:
None.
📸 Screenshots:
🙏 Reviewer Notes:
Focus review on: