Deposit-only vault composer #1776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinom9
reviewed
Oct 24, 2025
| ) VaultComposerSync(_vault, _assetOFT, _shareOFT) {} | ||
|
|
||
| /** | ||
| * @notice Cross-chain redemptions are disabled for this vault |
There was a problem hiding this comment.
Suggested change
| * @notice Cross-chain redemptions are disabled for this vault | |
| * @notice Redemptions are disabled for this vault |
| bytes32 /*_redeemer*/, | ||
| uint256 /*_shareAmount*/ | ||
| ) internal pure override returns (uint256 /*assetAmount*/) { | ||
| // Disable redemption to prevent cross-chain redemptions |
There was a problem hiding this comment.
Suggested change
| // Disable redemption to prevent cross-chain redemptions | |
| /// @dev Disable all redemptions |
|
|
||
| /** | ||
| * @notice Cross-chain redemptions are disabled for this vault | ||
| * @dev Users should interact with the vault directly for redemption |
There was a problem hiding this comment.
I'd add a comment about redeemAndSend reverting atomically, and lzCompose calls refunding to the original chain.
| @@ -0,0 +1,43 @@ | |||
| // SPDX-License-Identifier: UNLICENSED | |||
There was a problem hiding this comment.
Does it have to be unlicensed? Should we make it MIT?
There was a problem hiding this comment.
@TRileySchwarz thoughts?
There was a problem hiding this comment.
Should be same as the regular vault composer
Comment on lines
19
to
25
| /** | ||
| * @notice Creates a new cross-chain vault composer | ||
| * @dev Initializes the composer with vault and OFT contracts for omnichain operations | ||
| * @param _vault The vault contract implementing ERC4626 for deposit/redeem operations | ||
| * @param _assetOFT The OFT contract for cross-chain asset transfers | ||
| * @param _shareOFT The OFT contract for cross-chain share transfers | ||
| */ |
There was a problem hiding this comment.
Also super nit.
I would stick to the VaultComposerSync NatSpec comment.
/**
* @notice Initializes the VaultComposerSyncDepositOnly contract with vault and OFT token addresses
* @param _vault The address of the ERC4626 vault contract
* @param _assetOFT The address of the asset OFT (Omnichain Fungible Token) contract
* @param _shareOFT The address of the share OFT contract (must be an adapter)
*
* Requirements:
* - Share token must be the vault itself
* - Asset token should match the vault's underlying asset (overridable behavior)
* - Share OFT must be an adapter (approvalRequired() returns true)
*/Again, I'm ok with this as is.
tinom9
approved these changes
Oct 24, 2025
shankars99
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: