fix(testing): stabilize Lambda host shutdown - #392
Merged
Conversation
Cancel test transactions only after host shutdown begins, so the Lambda bootstrap recognizes intentional cancellation.
Propagate ApplicationStopping before test-server transactions cancel, preventing RuntimeSupport from retrying a canceled poll.
Prevent failed test-server shutdown from leaving Lambda hosts alive until CI times out.
ncipollina
approved these changes
Aug 18, 2026
ncipollina
left a comment
Collaborator
There was a problem hiding this comment.
Looks like a substantitive change. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize Lambda test-host lifecycle teardown by ordering test-server shutdown, cancelling bootstrap work when the host stops, and disposing hosts after startup failures. Reduce test noise by configuring Lambda host logging and using awaited host-start delegation tests.
Serialize coverage test target frameworks while this shared-host shutdown path runs, preventing concurrent test hosts from overlapping in CI.
Changes
LambdaTestServershutdown with the hosted Lambda bootstrap cancellation path.Validation
task formatDOTNET_NOLOGO=1 dotnet test --project tests/MinimalLambda.UnitTests/MinimalLambda.UnitTests.csproj --configuration Release -v q --filter-class "MinimalLambda.UnitTests.Application.LambdaApplicationTests" --minimum-expected-tests 1 --no-progress --no-ansi -p:TestTfmsInParallel=falseNotes for Reviewers
Coverage CI is intentionally serialized across target frameworks; regular build and test commands remain parallel. GitHub build check is currently pending.