Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #281

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func StringToBackendType(s string) BackendType {
}

type Store interface {
// Backend returns the backend type provider of the store.
// BackendType returns the backend type provider of the store.
BackendType() BackendType
// Verify verifies the given key-value pair.
Verify(ctx context.Context, key []byte, value []byte) error
Expand Down
2 changes: 1 addition & 1 deletion metrics/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func (m *Metrics) RecordRPCServerRequest(method string) func(status, mode, ver s
}
}

// RecordSecondaryPut records a secondary put/get operation.
// RecordSecondaryRequest records a secondary put/get operation.
func (m *Metrics) RecordSecondaryRequest(bt string, method string) func(status string) {
timer := prometheus.NewTimer(m.SecondaryRequestDurationSec.WithLabelValues(bt))

Expand Down
2 changes: 1 addition & 1 deletion store/generated_key/eigenda/eigenda.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func (e Store) Put(ctx context.Context, value []byte) ([]byte, error) {
return bytes, nil
}

// Backend returns the backend type for EigenDA Store
// BackendType returns the backend type for EigenDA Store
func (e Store) BackendType() common.BackendType {
return common.EigenDABackendType
}
Expand Down
2 changes: 1 addition & 1 deletion store/secondary.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (sm *SecondaryManager) FallbackEnabled() bool {
return len(sm.fallbacks) > 0
}

// handleRedundantWrites ... writes to both sets of backends (i.e, fallback, cache)
// HandleRedundantWrites ... writes to both sets of backends (i.e, fallback, cache)
// and returns an error if NONE of them succeed
func (sm *SecondaryManager) HandleRedundantWrites(ctx context.Context, commitment []byte, value []byte) error {
sources := sm.caches
Expand Down