refactor: Quality of Life Improvements #1006
Open
+486
−511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
changed the base branch from
slashing-magnitudes
to
slashing-magnitudes-fixes
0xClandestine
force-pushed
the
refactor/ci
branch
from
6375ea7 to
268e7be
Compare
0xClandestine
force-pushed
the
refactor/ci
branch
from
268e7be to
cd9f0b6
Compare
0xClandestine
force-pushed
the
refactor/ci
branch
from
cd9f0b6 to
12b40b0
Compare
0xClandestine
force-pushed
the
refactor/ci
branch
from
12b40b0 to
33be343
Compare
refactor: remove gas report fix: gas report fix: gas report refactor: continuous fuzzing refactor: cleanup feat: gas reporting feat: intense continuous fuzzing refactor: rename workflow files refactor: renaming refactor: ci refactor: renaming refactor: ci feat: add `FOUNDRY_PROFILE=lite` to ci refactor: small `foundry.toml` cleanup refactor: renaming fix: continuous fuzzing
0xClandestine
force-pushed
the
refactor/ci
branch
from
33be343 to
20d90d6
Compare
0xClandestine
commented
Jan 30, 2025
Comment on lines
+1
to
+28
| { | ||
| "contracts": [ | ||
| { | ||
| "name": "AVSDirectory", | ||
| "address": "0x135dda560e946695d6f155dacafc6f1f25c1f5af" | ||
| }, | ||
| { | ||
| "name": "DelegationManager", | ||
| "address": "0x39053D51B77DC0d36036Fc1fCc8Cb819df8Ef37A" | ||
| }, | ||
| { | ||
| "name": "RewardsCoordinator", | ||
| "address": "0x7750d328b314EfFa365A0402CcfD489B80B0adda" | ||
| }, | ||
| { | ||
| "name": "StrategyManager", | ||
| "address": "0x858646372CC42E1A627fcE94aa7A7033e7CF075A" | ||
| }, | ||
| { | ||
| "name": "StrategyFactory", | ||
| "address": "0x5e4C39Ad7A3E881585e383dB9827EB4811f6F647" | ||
| }, | ||
| { | ||
| "name": "EigenPodManager", | ||
| "address": "0x91E677b07F7AF907ec9a428aafA9fc14a0d3A338" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
This json defines the contracts used to generate a mainnet storage diff in the Forge / Test (Storage) workflow.
There was a problem hiding this comment.
Let's add the following:
- EigenPod - 0xd4018Ce9A041a9c110A9d0383d2b5E1c66Ae1513 (pod that is used today)
- stETH Strategy (on GH)
- EigenStrategy (on GH)
- A Permissionless Strat (let's use wBTC)
0xClandestine
requested review from
nadir-akhtar,
0xrajath,
8sunyuan and
ypatil12
|
Working towards better handing in the Forge / Test (Storage) workflow... NOTE: CI fuzz runs is currently set to NOTE: Commenting out certora workflow until they finish slashing specs. |
ypatil12
reviewed
Jan 30, 2025
ypatil12
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This change consolidates our development infrastructure to make it more maintainable. Currently, we have:
Modifications:
CI/CD Changes:
certora.ymlfor formal verification (commented out until certora finishes specs).checks.ymlfor linting and bindings.foundry.ymlfor testing (unit, integration, forked integration, storage, coverage).Project Structure:
bin/directory.CONTRIBUTING.mdto.github/.Testing:
DeployFromScratch.t.sol.foundry.toml.Result:
These changes will: