feat: enforce and track AVS to register metadata #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenli86
changed the title
ypatil12
reviewed
Jan 14, 2025
ypatil12
requested changes
Jan 14, 2025
8sunyuan
reviewed
Jan 23, 2025
| @@ -43,6 +43,10 @@ abstract contract AllocationManagerStorage is IAllocationManager { | |||
| /// Note: if set to 0, defaults to the AVS's address | |||
| mapping(address avs => IAVSRegistrar) internal _avsRegistrar; | |||
|
|
|||
| /// @dev Lists the AVSs who has registered metadata and claimed itself as an AVS | |||
| /// @notice bool is not used and if always true if the avs has registered metadata | |||
| mapping(address avs => bool) internal _avsRegisteredMetadata; | |||
There was a problem hiding this comment.
This would cause storage issues with our existing AllocationManager on preprod and testnet. This added mapping should be defined below _operatorSets
ypatil12
requested changes
Jan 23, 2025
| @@ -39,6 +39,10 @@ abstract contract AVSDirectoryStorage is IAVSDirectory { | |||
| /// @dev This storage will be deprecated once M2-based deregistration is removed. | |||
| mapping(address avs => mapping(address operator => OperatorAVSRegistrationStatus)) public avsOperatorStatus; | |||
|
|
|||
| /// @dev Lists the AVSs who has registered metadata and claimed itself as an AVS | |||
| /// @notice bool is not used and if always true if the avs has registered metadata | |||
There was a problem hiding this comment.
This needs to be added after operatorSaltIsSpend, otherwise the storage is overwritten
| @@ -43,6 +43,10 @@ abstract contract AllocationManagerStorage is IAllocationManager { | |||
| /// Note: if set to 0, defaults to the AVS's address | |||
| mapping(address avs => IAVSRegistrar) internal _avsRegistrar; | |||
|
|
|||
| /// @dev Lists the AVSs who has registered metadata and claimed itself as an AVS | |||
| /// @notice bool is not used and if always true if the avs has registered metadata | |||
| mapping(address avs => bool) internal _avsRegisteredMetadata; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr illustrates what changes are needed in protocol
once confirmed, pr will be polished and tests will be updated/added.
afterwards, we will either run the migration ourselves to populate the var in existing AVSDirectory should be done separately, or ask avs to resubmit their metadata