fix: ep negative shares bug #1033
Open
+216
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
fix/ep-negative-shares-bug
branch
from
d4a2441 to
0c7a702
Compare
|
Proof of failure on bringing old logic back: 
|
eigenmikem
approved these changes
Jan 24, 2025
8sunyuan
reviewed
Jan 27, 2025
| return (prevDepositShares < 0 ? 0 : uint256(prevDepositShares), shares); | ||
| // If we have gone from negative to positive shares, return (0, positive delta) | ||
| else if (prevDepositShares < 0) { | ||
| return (0, uint256(prevDepositShares + sharesToAdd)); |
There was a problem hiding this comment.
nit: can this just be return (0, uint256(updatedDepositShares))? we do this addition above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the negative shares edge case where an operator is overrewarded shares if a staker, who previously had negative shares, completes a withdrawal as shares. Integration upgrade tests have been added to verify behavior.