feat: add OperatorSharesSlashed event to track shares slashed per operator #1051
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
reviewed
Jan 27, 2025
| @@ -307,6 +307,9 @@ contract DelegationManager is | |||
| sharesToDecrease: operatorSharesSlashed | |||
| }); | |||
|
|
|||
| // Emit event for operator shares being slashed | |||
| emit OperatorSharesSlashed(operator, strategy, totalDepositSharesToBurn); | |||
There was a problem hiding this comment.
To confirm, you are trying to get what was slashed of the operator that was also in the queue? In this case, the OperatorSharesDecreased event will not map 1:1 with the OperatorSharesSlashed event in terms of magnitude of burned shares (since some could have been in the queue).
There was a problem hiding this comment.
yes, that'll have more meanings so we are not simply having value-duplicated events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add OperatorSharesSlashed event to track shares slashed per operator