Skip to content

Fix multi-digit SemVer major parsing in SemVerMixin #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix multi-digit SemVer major parsing in SemVerMixin #1627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/contracts/mixins/SemVerMixin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,18 @@ abstract contract SemVerMixin is ISemVerMixin {
}

/// @notice Returns the major version of the contract.
/// @dev Supports single digit major versions (e.g., "1" for version "1.2.3")
/// @dev Supports multi-digit major versions (e.g., "10" for version "10.2.3").
/// @return The major version string (e.g., "1" for version "1.2.3")
function _majorVersion() internal view returns (string memory) {
bytes memory v = bytes(_VERSION.toString());
return string(abi.encodePacked(v[0]));
uint256 end;
while (end < v.length && v[end] != 0x2e) { // '.'
end++;
}
bytes memory major = new bytes(end);
for (uint256 i = 0; i < end; i++) {
major[i] = v[i];
}
return string(major);
}
}