Fix Eigen.totalSupply to return EIGEN supply (not bEIGEN) for ERC20/Votes consistency #1656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary: Align
Eigen.totalSupply()with ERC20/Votes expectations by returning the EIGEN token’s own supply viasuper.totalSupply()instead ofbEIGEN.totalSupply().Changes
src/contracts/token/Eigen.sol: ReplacetotalSupply()implementation to callsuper.totalSupply()and update the comment.Rationale
bEIGEN.totalSupply()breaks ERC20 invariants and may corruptERC20VotesUpgradeableaccounting and external indexers relying ontotalSupply().