Skip to content

chore(index-registry): add QuorumAlreadyExists error #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

itsmehdiabdi
Copy link

Motivation:

The existing logic used the QuorumDoesNotExist error even in the case when a quorum already existed. This was misleading and did not properly reflect the error scenario. Accurate error handling is essential for debugging and for ensuring clarity during interactions with the contract.

Modifications:

  • Introduced a new custom error QuorumAlreadyExists in the IndexRegistryErrors interface.
  • Updated the initializeQuorum function in IndexRegistry to use the new QuorumAlreadyExists error when a quorum is already initialized.

Result:

  • The error handling logic is now more precise.
  • Developers and users will get clearer feedback when attempting to initialize an already existing quorum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant