Guard logs by verbose #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbrower95
commented
Aug 30, 2024
jbrower95
commented
- We missed a few logs during checkpoint proof generation that make parsing output more difficult.
- Remove these logs to fix the command -- they should only show up with --verbose.
gpsanant
reviewed
Aug 30, 2024
| color.Yellow("Submit these proofs to network and re-run with `status` to see the updated Eigenpod state.") | ||
| if verbose { | ||
| if !noSend { | ||
| color.Green("Complete! re-run with `status` to see the updated Eigenpod state.") |
There was a problem hiding this comment.
maybe we should do this if it's verbose or not?
There was a problem hiding this comment.
nope
a good chunk of the people using the CLI are just throwing it in a CI / automated process
they are likely parsing out this and ignoring it anyways
anyone using the CLI manually (e.g for tests) likely should be using --verbose.
gpsanant
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.