Make status significantly faster
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetOnchainValidatorInfomultiple times in status, due to a regression introduced in one of our PRs.statusabout 60~ cheaper to run on average, in terms of network calls.Results
Before:
./cli status --podAddress 0x2641C2ded63a0C640629F5eDF1189e0f53C06561 9.57s user 9.35s system 4% cpu 7:38.89 total(458s)After:
./cli status --podAddress 0x2641C2ded63a0C640629F5eDF1189e0f53C06561 7.24s user 6.09s system 4% cpu 4:52.41 total(292s)Overall about a 36% reduction in time for the command.