Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deneb cleanup #22

Merged
merged 15 commits into from
Jan 25, 2024
Merged

Deneb cleanup #22

merged 15 commits into from
Jan 25, 2024

Conversation

gpsanant
Copy link
Contributor

major cleanup on the deneb branch

@joan-el joan-el requested review from bowenli86 and Sidu28 January 23, 2024 16:13
@@ -743,3 +744,135 @@ func ComputeExecutionPayloadFieldRootsDeneb(executionPayloadFields *deneb.Execut

return executionPayloadFieldRoots, nil
}

func ComputeExecutionPayloadFieldRootsCapella(executionPayloadFields *capella.ExecutionPayload) ([]phase0.Root, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is capella in deneb.go?

Copy link
Contributor

@Sidu28 Sidu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sidu28 Sidu28 merged commit 882b112 into deneb Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants