Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Operator methods missing, form Go SDK #280

Merged
merged 45 commits into from
Feb 20, 2025
Merged

feat: Operator methods missing, form Go SDK #280

merged 45 commits into from
Feb 20, 2025

Conversation

pablodeymo
Copy link
Collaborator

@pablodeymo pablodeymo commented Feb 4, 2025 •
edited
Loading

Fixes #

types/operator is missing the following functions

  • Operator.Validate
  • OperatorPubkeys.ToContractPubkeys
  • OperatorIdFromContractG1Pubkey
  • OperatorIdFromKeyPair
  • G1PubkeyFromContractG1Pubkey

What Changed?

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@pablodeymo pablodeymo changed the title [WIP] operator/validate WIP [WIP] Operator methods missing, form Go SDK Feb 6, 2025
pablodeymo and others added 26 commits February 14, 2025 15:42
@pablodeymo
Merge branch 'dev' into operator_validate
db4434c
@pablodeymo
progress in point conversion
8f14f84
@MegaRedHand
refactor: remove vec from operator ID calculation
c7cbc3a
@pablodeymo
fix alloy feature used
6973d89
@pablodeymo
to_contract_public_keys
ffc21a5
@pablodeymo
refactor in files
ce9541a
@pablodeymo
fix tests
e0775a2
@MegaRedHand
feat: add error and comments
8227557
@MegaRedHand
feat: add checks for name and description
3cd5d9a
@MegaRedHand
chore: update deps
5e64784
@MegaRedHand
chore: fix clippy lints
d734632
@MegaRedHand
feat: add website checks
9efe146
@MegaRedHand
feat: add twitter validation
872de46
@pablodeymo
test_operator_pub_keys
a4dd4ae
@MegaRedHand
test: add tests for operator metadata
2a301c7
@pablodeymo
ark-bn254 as dev dependency
ba39126
@pablodeymo
is_valid_ethereum_address
14ba3e3
@pablodeymo
using OnceLock
a9a7a80
@MegaRedHand
test: move common data to function
a24a21b
@MegaRedHand
test: add tests for invalid cases
1607623
@MegaRedHand
refactor: change validate to be async
7246aa8
@pablodeymo
removed unused atribute in Operator
945acf3
@pablodeymo
comment in is_valid_ethereum_address, and check if address is Zero
d46e438
@pablodeymo
operator.rs: new method and progress in validate
46bfab0
@pablodeymo
Operator::validate implemented
e57f883
@MegaRedHand
feat: check server returns a PNG image
a1c63e4
@MegaRedHand MegaRedHand added the changelog-added [changelog] PR adds a new feature label Feb 17, 2025
@pablodeymo pablodeymo changed the title [WIP] Operator methods missing, form Go SDK feat: Operator methods missing, form Go SDK Feb 17, 2025
@pablodeymo pablodeymo marked this pull request as ready for review February 17, 2025 20:02
supernovahs
supernovahs reviewed Feb 19, 2025
View reviewed changes
@supernovahs supernovahs merged commit 944a8e4 into dev Feb 20, 2025
11 checks passed
@supernovahs supernovahs deleted the operator_validate branch February 20, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@supernovahs supernovahs supernovahs approved these changes

Assignees
No one assigned
Labels
changelog-added [changelog] PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablodeymo @MegaRedHand @supernovahs