Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add set_signer method in Writer methods #364

Merged
merged 4 commits into from
Feb 19, 2025
Merged

add set_signer method in Writer methods #364

merged 4 commits into from
Feb 19, 2025

Conversation

supernovahs
Copy link
Collaborator

Fixes #334

What Changed?

Added set-signer method .

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@supernovahs supernovahs changed the base branch from main to dev February 19, 2025 12:44
@supernovahs
Copy link
Collaborator Author

@MegaRedHand let me know what you think of this change. then I'll update changelog if it looks good

@MegaRedHand
Copy link
Contributor

LGTM, but why did you feel this was needed? Or did someone request it?

@pablodeymo wdyt?

@supernovahs
Copy link
Collaborator Author

LGTM, but why did you feel this was needed? Or did someone request it?

@pablodeymo wdyt?

when working on IS and tests , i wanted to give permission using different signers, registering the operator with different keys, had to initialize 2 el_writers

MegaRedHand
MegaRedHand previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaRedHand
Copy link
Contributor

There's an unneeded import

@MegaRedHand MegaRedHand dismissed their stale review February 19, 2025 18:36

Changelog update is missing

@supernovahs supernovahs added the changelog-added [changelog] PR adds a new feature label Feb 19, 2025
@MegaRedHand MegaRedHand merged commit c9cdb6f into dev Feb 19, 2025
12 checks passed
@MegaRedHand MegaRedHand deleted the nova/update_signer_in_writer branch February 19, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
changelog-added [changelog] PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow changing signer key and provider url in ELReader, ELWriter , AvsReader and Writer
2 participants
@supernovahs @MegaRedHand