refactor and clean up encoding #7
Conversation
|
|
||
| // fn pointer indirection fools the compiler into letting us have | ||
| // an uninitialized storage pointer | ||
| function() pure returns (mapping(uint => MultisigCall[]) storage) fn; |
There was a problem hiding this comment.
sol devs would rather do this than just contribute to the compiler LMAO
| /// @dev Encodes a call to `ProxyAdmin.upgrade(proxy, impl)` | ||
| function upgrade(EncProxyAdmin, address proxy, address impl) internal pure returns (bytes memory) { | ||
| return abi.encodeCall(IProxyAdmin.upgrade, (ITransparentUpgradeableProxy(proxy), impl)); | ||
| } |
There was a problem hiding this comment.
IMO nit but it feels like it would be more straightforward to leave abi.encodeCall(IProxyAdmin, to, params)
but make zDeployedProxy cast to ITransparentUpgradeableProxy by default...
There was a problem hiding this comment.
im not super sure what you're asking for, but this is less about how ZeusScript uses it and more about how this works when writing upgrade scripts. for upgrade scripts this is much nicer.
i can share examples if you want
| for (uint256 i = 0; i < calls.length; i++) { | ||
| packedCalls = abi.encodePacked( | ||
| packedCalls, | ||
| abi.encodePacked(uint8(0), calls[i].to, calls[i].value, uint256(calls[i].data.length), calls[i].data) |
There was a problem hiding this comment.
would normally link to https://github.com/safe-global/safe-smart-account/blob/main/contracts/libraries/MultiSend.sol#L20 for this gibberish xD
No description provided.