Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cargo-sweep to v2.0.0 #38

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Update to cargo-sweep to v2.0.0 #38

merged 5 commits into from
Oct 30, 2024

Conversation

BD103
Copy link
Collaborator

@BD103 BD103 commented Oct 30, 2024

Please see the release notes here. Closes #36.

This PR updates our dependency on BD103/cargo-sweep to v2.0.0. In the process it deprecates the cache-cargo-sweep input, since that no longer has any effect. (The cargo-sweep binary is no longer installed, instead its logic is replicated by the action in Javascript.)

This also fixes a bug where cargo-sweep was run even when set to false. Oops!

I specifically made this change backwards-compatible so it can be released in v2.5.0. Once v3.0.0 is released, we can permanently remove cache-cargo-sweep and set sweep-cache to true by default.

@BD103 BD103 changed the title Update to cargo-sweep v2.0.0 Update to cargo-sweep to v2.0.0 Oct 30, 2024
@BD103 BD103 added bug Something isn't working enhancement New feature or request labels Oct 30, 2024
@BD103 BD103 requested a review from TimJentzsch October 30, 2024 21:11
@BD103
Copy link
Collaborator Author

BD103 commented Oct 30, 2024

To view the effects of sweep-cache: true, see this run where I temporarily set it in CI.

@BD103 BD103 merged commit 9947fd4 into main Oct 30, 2024
3 checks passed
@BD103 BD103 deleted the cargo-sweep-2.0.0 branch October 30, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to locate cargo-sweep with a self-hosted runner
2 participants