Skip to content

B2CA-2263: app broken#128

Merged
cedelavergne-ledger merged 8 commits intodevelopfrom
cev/B2CA-2263_app-broken
Sep 12, 2025
Merged

B2CA-2263: app broken#128
cedelavergne-ledger merged 8 commits intodevelopfrom
cev/B2CA-2263_app-broken

Conversation

@cedelavergne-ledger
Copy link
Contributor

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@AlekEagle
Copy link

Happy to see this PR opened, I really enjoyed using my Ledger as my preferred GPG hardware keystore and I'd like to get back to using it as such. I can test this firmware tomorrow when I have a chance.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.07%. Comparing base (e605d57) to head (e616a96).

Files with missing lines Patch % Lines
src/gpg_io.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #128   +/-   ##
========================================
  Coverage    36.07%   36.07%           
========================================
  Files            4        4           
  Lines          255      255           
  Branches        35       35           
========================================
  Hits            92       92           
  Misses         163      163           
Flag Coverage Δ
unittests 36.07% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-2263_app-broken branch 3 times, most recently from 943bdea to de9f401 Compare September 11, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants