Merged
Conversation
Issue: The application freezes during GPG initialization (command `GET_DATA` `0x6E`) when using a hybrid ECC key configuration. Root Cause: The response payload size (246 bytes) triggers a transport layer freeze on the physical device (T=0 protocol). While technically within the Short APDU limit (256 bytes), sending a payload this close to the maximum size causes the Host/Driver to fail capturing the Status Word correctly, resulting in a timeout. Fix: Reduced the 0x6E response size to ~224 bytes by omitting the optional Historical Bytes (Tag `5F 52`). This "safe" size avoids the T=0 transport edge-case.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #143 +/- ##
========================================
Coverage 36.13% 36.13%
========================================
Files 4 4
Lines 238 238
Branches 35 35
========================================
Hits 86 86
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: The application freezes during GPG initialization (command
GET_DATA0x6E) when using a hybrid ECC key configuration.Root Cause: The response payload size (246 bytes) triggers a transport layer freeze
on the physical device (T=0 protocol).
While technically within the Short APDU limit (256 bytes), sending a payload this close to the maximum size causes the Host/Driver to fail capturing the Status Word correctly, resulting in a timeout.
Fix: Reduced the 0x6E response size to ~224 bytes by omitting the optional Historical Bytes (Tag
5F 52). This "safe" size avoids the T=0 transport edge-case.This PR fixes #135