-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 자동, 수동 매칭 리스트에서 사용할 카드 UI 구현 #12
Open
WooGi1020
wants to merge
21
commits into
main
Choose a base branch
from
feat/matching-card-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,846
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
관련 이슈 번호 #9
Close #9
🚀 작업 내용
자동 매칭, 수동 매칭에서 사용하는 각 카드 UI와 수동매칭 시트에서 카테고리별 리스트 렌더링 작업 진행했습니다!
겸사겸사 저희 기존 웹에서 사용하던 공통 버튼도 작성했습니다!
그런데 UI 로직 작성하면서
state
관련 로직 작성하고.. 더미 데이터 사용하면서 모델 작성하고... 하다보니 코드가 좀 많이 길어졌어요 😭😭보통 플러터 개발 시 UI 구현은 진짜 생짜로 UI만 작성하는건지, 아니면 UI관련 상태관리 로직까지 다 작성하는지 모르겠는데 일단 분량조절 실패는 맞는 것 같습니다... 양해를 🙇♂️🙇♂️🙇♂️
📸 스크린샷
2025-03-11.013714.mp4
2025-03-11.013746.mp4
📢 리뷰 요구사항
TapBar
의 프로필 같은 경우 개별적인 스크린으로 이동하는 로직이 될 예정이라 일단 채팅스크린으로 이동하도록 해두었습니다! (추후 변경 예정)그리고 지금
MatchingCard
같은 경우에 확장시에 높이가 넘칠 때 보이는 경고 UI가 렌더링되는데... 최대로 확장되고 나면 사라집니다 😂 아무래도 늘어나는 시간이 있다보니까 늘어나는 동안만 높이가 넘치고, 늘어난 후엔 정상화되는 그런 느낌인 것 같은데 이걸 어떻게 수정해야할지 감이 안잡혀서 피드백을 받고 싶습니다!!