Conversation
As far as I can tell, no current mods use this.
secure only!
ah-OOG-ah
changed the title
Member
Author
|
This crashes in NH daily 243, due to MixinExtra not loading for a preinit mixin. Unsure if this broke MixinExtra in general, or just in preinit |
Member
Author
|
Update: fixed the issue, this should be ready for testing now |
mitchej123
approved these changes
Dec 18, 2025
Member
Author
|
Tested it in GTNH (daily 243) and one version of @brandyyn's modpack, no breakage found. |
mitchej123
requested review from
a team,
FalsePattern,
Roadhog360,
basdxz,
embeddedt,
jss2a98aj and
unix-supremacist
embeddedt
approved these changes
Dec 25, 2025
basdxz
reviewed
Dec 25, 2025
Contributor
basdxz
left a comment
basdxz
left a comment
There was a problem hiding this comment.
Looks fine, outside of the unmentioned import and formatting changes which really should have been their own separate housekeeping pr.
Member
|
Spotless forces that I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching on GitHub brings up no current mods using this, and it's been about two years since it was last possible to reference from an IDE (see 87e71b1).
Also: