Fix migration problems with initially deferred and not null constraints #5533
Conversation
Executes `SET CONSTRAINTS xyz IMMEDIATE;` before `CREATE INDEX` and `ALTER COLUMN` that otherwise fail because of "pending trigger events".
matc-pub
requested review from
dessalines,
phiresky and
dullbananas
as code owners
| ALTER TABLE post | ||
| ALTER COLUMN instance_id SET NOT NULL; |
There was a problem hiding this comment.
Dopped the DEFAULT 0 here.
| @@ -37,6 +37,10 @@ ALTER TABLE comment | |||
| DROP COLUMN report_count, | |||
| DROP COLUMN unresolved_report_count; | |||
|
|
|||
| SET CONSTRAINTS comment_aggregates_comment_id_fkey IMMEDIATE; | |||
There was a problem hiding this comment.
It seems like these SET CONSTRAINTS IMMEDIATE statements are immediately overwritten and could be removed.
There was a problem hiding this comment.
https://www.postgresql.org/docs/current/sql-set-constraints.html:
SET CONSTRAINTS — set constraint check timing for the current transaction
^ only the current transaction
When SET CONSTRAINTS changes the mode of a constraint from DEFERRED to IMMEDIATE, the new mode takes effect retroactively: any outstanding data modifications that would have been checked at the end of the transaction are instead checked during the execution of the SET CONSTRAINTS command.
Changing the constraint back to DEFERRED is probably only necessary when the same transaction later again updates the table or the referenced table, but should have little impact if it doesn't.
There was a problem hiding this comment.
Good catch, thx.
@dullbananas should also have a look as there might be others.
|
Thanks! |
Executes
SET CONSTRAINTS xyz IMMEDIATE;beforeCREATE INDEXandALTER COLUMNthat otherwise fail because of "pending trigger events".These errors only show up when the tables hold data during the migrations.
Fixes #5531