Fixed decrement / accumulator addition#1
Open
connornishijima wants to merge 1 commit intoLenShustek:masterfrom
connornishijima:master
Open
Fixed decrement / accumulator addition#1connornishijima wants to merge 1 commit intoLenShustek:masterfrom connornishijima:master
connornishijima wants to merge 1 commit intoLenShustek:masterfrom
connornishijima:master
Conversation
Owner
|
That's actually not correct. Line 356 is the initialization of the accumulator for a new note that is starting, so the current value is undefined. The code with the "+=" that matches the pseudocode is line 480. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the accumulator throws out division remainders leading to "frequency stepping" in higher frequencies. The code now matches the comment block showing pseudocode for this function.