Ssl fingerprints #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ba391f hardforks: set mainnet and stagenet v15/16 fork height (selsta)
fe5d1be build: prepare v0.18.0.0 (selsta)
cf3be99 Template hash func to fix compiler error on < gcc-6 (j-berman)
it's very spammy and drowns the test output
That RPC will wait for mining to actually stop, which can be a while if randomx has just started on randomx_init_dataset. This fixes occasional failures in the mining functional test
@jtgrassie pointed out that the example I provided was colored incorrectly. He also made the good point that the image wasn't easy to review/correct. I reworked the example so that it's text-only. It's easier to review and edit, and reveals the structure better in my opinion. Also this is easier for people who can't distinguish colors as easily. Make sure to double-check this work because there's a decent chance I screwed up the comments. The actual byte data was generated and should be solid.
Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load. After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).
Otherwise Ledger rejects the wallet.
on my anecdotal SSD, goes from about 9 hours to 1h20.
- only allow offline wallets to import outputs - don't import empty outputs - export subaddress indexes when exporting outputs
this will make it easier huge wallets to do so without hitting random limits (eg, max string size in node).
d89e7a2 util: make GMT timestamps explicit for clarity (moneromooo-monero)
5b4fea7 Copyright: Update to 2023 (mj-xmr)
9c7d28b wallet2: add on_reorg callback (Crypto City)
1082720 README: fix void ssl package (tobtoht)
9e09093 wallet_rpc_server: allow creating more than 64 addresses at once (moneromooo-monero)
11a8360 simplewallet: print fully qualified filename for new wallets (moneromooo-monero)
Using post-PR wallet with pre-PR node will generate error message specific to this PR and not generic "command failed" mesages.
5a7a5f1 build: BUILD_DEBUG_UTILITIES fix (Jeffro256)
b13ddb9 Handle case where a command line flag is not allowed in the config file (almalh)
630906c cryptonote_basic: remove unused struct (tobtoht)
2eaa523 cryptonote::transaction_prefix: fix IDE parsing error (koe)
4e16559 rpc: give reason when sending non-hex raw tx (jeffro256)
c61d33e wallet2: fix outdated wallet check (Crypto City)
df9aa6b epee: remove dead code in net_helper (Jeffro256)
3a34c63 depends: cleanup Makefile (tobtoht)
7a4a03d wallet2: do not commit transactions more than once (moneromooo-monero)
833dd6b add libunbound to package list for OpenBSD (Nihal Jere)
f383fd3 wallet2: make m_process_pool_txs local to refresh method (jeffro256)
eb0e405 gamma picker: relax constructor requirements and test for selecting outputs from first spendable block (jeffro256)
d2a591d wallet, simplewallet: Drop support for mine-to-use RPC system (Jeffrey Ryan)
4080796 serialization: remove unused function dump_json (Jeffrey Ryan)
1698cb1 remove defunct light wallet code (tobtoht)
c32befe fix missing <cstdint> includes (tobtoht)
jeffro256
force-pushed
the
ssl_fp_file
branch
2 times, most recently
from
9324d49 to
58ab9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
26 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code by @jeffro256