Open
Conversation
Backport _xmlOptions
Fix tableCells()
Don't default to app, as it prevents generating code coverage for core and plugin files. Fixes cakephp#6533
The second parameter of rtrim is a character mask, not a string to be replaced. It was breaking file names ending in one or more 'p' or 'h' characters.
Replace rtrim with preg_replace in SchemaShell
When inflecting irregular values, both plural and singular forms were generated incorrectly. Fixes cakephp#6538
Underscore separated words were not catched by the irregular regex, tests however didn't fail as the default rules matched the tested words too. The added test should ensure that this won't happen again. Fixes the gap left by the previous cakephp#6538 fix.
Add underscore support for multi word irregulars.
2.6 Add missing HTML minimize attributes
Deprecate notEmpty in favor of notBlank.
Was a left-over from cakephp#6579
Rename test methods after notBlank change
DboSource::_quoteFields() is already a bit of a mess, and while I'm not happy about having to add more regex replacement, it seems to be the only reasonable solution given that the code is already 'parsing' SQL to apply identifier quoting. Fixes cakephp#6602
SQLite does not handle subqueries in virtual fields well. However, the original issue was that the generated query was invalid which find(first) will still catch.
Fix incorrectly quoted table aliases in virtual fields.
Don't include deprecated validators in bake. Refs cakephp#6581
Exclude deprecated validators from bake.
Mostly CS, doc blocks and explicit returning nulls.
Mostly CS, doc blocks and unused variables.
Mostly CS, doc blocks and some CSS
Various improvements to the CakePHP lib files
Add cakephp/cakephp-codesniffer as dev dependency
App & skel folder sync + some improvements
Various improvements to the CakePHP test files
Link to DebugKit 2.2 branch
Update debugkit links to 2.x compatible branch
Load config file before checking class existence.
Instead of viri, it should be viruses. Refs cakephp#7466
These variables are used by the HTML test reporter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds stability and fixes some issues (e.g. late static binding)
Biggest change is the deprecation of String => CakeText.
Changes: http://book.cakephp.org/2.0/en/appendices/2-7-migration-guide.html