Skip to content

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Aug 21, 2025

  • Remove finalize return and argument
  • Add get/export_data function.
  • Ensure finalize finishes any comms with remote process (and shuts down) so export simply returns data.
  • Add user_fields option to export to return H with user fields (e.g., beam_length)
  • Add tests for new unmapping function + finalize/export.

@jlnav
Copy link
Member

jlnav commented Aug 21, 2025

Good catch. Thankfully I believe I adjusted the runner recently to not suggest/ingest data from finalize anymore,

        tag, Work, H_in = self.ps.send_recv(H_out)  # evaluate the initial sample
        final_H_out = self._start_generator_loop(tag, Work, H_in)
        self.gen.finalize()

but the signature obviously was still incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants