-
Notifications
You must be signed in to change notification settings - Fork 27
Update finalize to meet standard #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shuds13
wants to merge
17
commits into
experimental/jlnav_plus_shuds_asktell
Choose a base branch
from
feature/update_finalize
base: experimental/jlnav_plus_shuds_asktell
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update finalize to meet standard #1582
shuds13
wants to merge
17
commits into
experimental/jlnav_plus_shuds_asktell
from
feature/update_finalize
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good catch. Thankfully I believe I adjusted the runner recently to not suggest/ingest data from finalize anymore, tag, Work, H_in = self.ps.send_recv(H_out) # evaluate the initial sample
final_H_out = self._start_generator_loop(tag, Work, H_in)
self.gen.finalize() but the signature obviously was still incorrect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalize
finishes any comms with remote process (and shuts down) soexport
simply returns data.user_fields
option toexport
to return H with user fields (e.g.,beam_length
)