Skip to content

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Aug 22, 2025

No description provided.

jlnav added 3 commits August 21, 2025 15:48
…documenting, and so we don't have to check the existence of settings in kwargso
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.93%. Comparing base (6b54991) to head (4357173).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           experimental/jlnav_plus_shuds_asktell    #1583      +/-   ##
=========================================================================
- Coverage                                  89.95%   89.93%   -0.03%     
=========================================================================
  Files                                         79       79              
  Lines                                       7915     7925      +10     
  Branches                                    1176     1178       +2     
=========================================================================
+ Hits                                        7120     7127       +7     
- Misses                                       615      618       +3     
  Partials                                     180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gen_specs["user"]["xtol_abs"] = xtol_abs
gen_specs["user"]["ftol_abs"] = ftol_abs
gen_specs["user"]["dist_to_bound_multiple"] = dist_to_bound_multiple
gen_specs["user"]["max_active_runs"] = max_active_runs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIELDS = [
    "initial_sample_size",
    "sample_points",
    "localopt_method",
    "rk_const",
    "xtol_abs",
    "ftol_abs",
    "dist_to_bound_multiple",
    "max_active_runs",
]

u = gen_specs.setdefault("user", {})
temp = {}
for k in FIELDS:
    val = locals().get(k)
    if val is not None:
        temp[k] = val
u.update(temp)

or separate required v optional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this works but grabbing values from locals() to prevent redundancy just looks odd to me. I can still implement this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just a way to convert a string to a function name. Better than typing them all out right?

jlnav added 2 commits August 22, 2025 13:37
… with loop over fields and grabbing the value from locals, as suggested by shuds
@jlnav jlnav requested a review from shuds13 August 26, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants