-
-
Notifications
You must be signed in to change notification settings - Fork 126
scroll guides menu independently #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
_includes/inline-style.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer auto, scroll will always render the scroll bar even if it's not needed
_layouts/home.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style="" really shouldn't be used, put it in the appropriate <style> tag
_includes/inline-style.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using position: sticky without an inset (top/bottom/left/right) feels odd, it's got no place to stick to. what's the desired effect?
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
_includes/inline-style.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like a bad idea, why hide it?
_includes/inline-style.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like this will have the effect that the footer will always be on screen? instead of being off screen on long pages?
77223bd to
95804f8
Compare
this feel kinda janky, let me know if you can think of a better way to do this
closes #39