fixes #75 #77
Merged
fixes #75 #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke bag validation on Windows when using multiprocessing. Closes LibraryOfCongress#42
Similar to LibraryOfCongress#59 , large verifications of multiple files can take a long time, so having more status updates is more meaningful and reassuring. Let me know if I put this in the wrong place/function.
Reset self.entries to empty when (re)loading manifests to catch when files have been deleted from the bag.
…le selection
|
LGTM |
acdha
reviewed
Oct 25, 2016
| p = join(dir_name, filename) | ||
| yield os.path.relpath(p, bag_dir) | ||
| for dir in os.listdir(bag_dir): | ||
| if dir != 'data': |
There was a problem hiding this comment.
I generally prefer an early exit (if dir == 'data': continue) rather than indenting a large block but I'm not sure how important that is
| #remove everything up to the bag_dir directory | ||
| p = join(dir_name, filename) | ||
| yield os.path.relpath(p, bag_dir) | ||
| for dir in os.listdir(bag_dir): |
There was a problem hiding this comment.
dir is a builtin Python function - it probably won't break anything but I prefer not use redefine those names where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the selection of tag files as reported by issue #75