Skip to content

Adding geocoding HABS/HAER/HALS project #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

SabrinaTT7
Copy link
Collaborator

This will add the notebook and supporting files for the geocoding project with HABS/HAER/HALS

@beefoo
Copy link
Collaborator

beefoo commented Jul 16, 2025

I think this looks great! This will be the perfect notebook for us to link to for anyone trying to use our collections from a geospatial perspective. I only have two relatively minor notes on formatting and these are just my opinion/suggestions and not a rule:

Where possible, print data as a table using Pandas. In some cases, the data will need to be transposed, e.g.

image

Generally, I like to have some kind of output within a single code block. This gives me some feedback if I am executing each block manually. E.g.

image

Similarly, I may want to see progress in a loop that takes longer than ~10s, e.g.

image

Otherwise, this looks good to merge when you're ready!

@SabrinaTT7 SabrinaTT7 marked this pull request as ready for review July 16, 2025 20:50
@beefoo beefoo merged commit 1f68eaa into master Jul 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants