Skip to content

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Aug 23, 2020

It's a 2.5mm right-angle 2-pos connector often used for RC LiPo batteries.

I re-used the generic pin header symbol.

Footprint verification in real project pending.

@dbrgn dbrgn self-assigned this Aug 23, 2020
@dbrgn dbrgn added the addition New library element. label Aug 26, 2020
@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 2, 2020

Hmm, the size is correct but the holes are a bit too tight... I can barely squeeze in the connector because it has bent legs.

I increased the drill size a bit, 1mm should work fine according to my tests.

@dbrgn dbrgn marked this pull request as ready for review October 2, 2020 12:26
@dbrgn dbrgn added the ready for review Waiting for review by maintainers. label Oct 2, 2020
@dbrgn dbrgn requested a review from ubruhin October 2, 2020 12:26
@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 2, 2020

image

@dbrgn dbrgn assigned ubruhin and unassigned dbrgn Oct 16, 2020
@ubruhin
Copy link
Contributor

ubruhin commented Oct 20, 2020

I re-used the generic pin header symbol.

Why not even reusing the corresponding component? Somehow it feels quite wrong to not use the existing pin header components since this connector is a pin header ;)

@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 21, 2020

That would mean that it's reasonable to swap the JST connector with a generic pin header when assigning devices in the board editor... I'm not sure if that's a good idea, but you're right that technically JST connectors are just a special form of a pin header, so I'll replace the component with the generic one.

@ubruhin
Copy link
Contributor

ubruhin commented Oct 22, 2020

That would mean that it's reasonable to swap the JST connector with a generic pin header when assigning devices in the board editor.

Yes, I'd say that's fine 👍

Now you should remove the obsolete component 😉 And maybe you want to generate a new UUID for the device to avoid issues when updating the project library if you already used the device in projects (could be done by duplicating the device and then removing the old one).

@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 22, 2020

Good catch 😄

I removed the old cmp and changed the dev UUID.

@p0kR
Copy link

p0kR commented Mar 27, 2024

Hello everybody,
I just came across this old merge request when searching for JST XH connectors.

Just in case this might have been forgotten, I wanted to show you, there is still interest in this topic :)

@p0kR
Copy link

p0kR commented Mar 27, 2024

@dbrgn in #2 I saw, you suggested to also add versions of other pins counts. I think, if this is not too complicated, it would be useful for these XH connectors here, too.

I'm still very inexperienced with LibrePCB, but if this pull request will be accepted and you don't want to create other pin-count versions, I might try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

3 participants