Skip to content

Conversation

agagniere
Copy link

@agagniere agagniere commented Apr 13, 2024

Hi, here is one of the simplest logic gate, to get started.

The objective is to understand what design is considered acceptable in this repo, with a simple-to-review PR, before moving on to more advanced components.

Quad 2-input AND Gate

Added:

  • 3 symbols

    • single (3 pins) AND symbol
    • 2-bits AND symbol
    • 4-bits AND symbol
  • 14 pins component representing an IC with 4 AND gates plus GND and Vcc
    It has 3 possible representations:

    • either 4 binary gates
    • or two 2-bit gates
    • or a single 4-bit gate

    All representations include a 2-pins connector for GND and Vcc

DATASHEETS / REFERENCES

The devices will be added in a separate PR in the Toshiba library

OPEN QUESTIONS / UNRESOLVED ISSUES

  • The Low and High voltage pins are sometimes named Vss and Vdd (e.g. TC4081B ), sometimes GND and Vcc... For now I used GND and Vcc, let me know what is preferred for this generic component
  • The generic 2-pins connector used for GND and Vcc is so narrow the pin names do not fit. Should I do something to the symbol or to the pin names ? maybe calling them L and H will do ? Found the right connector !
  • I did not populate the keywords apart from "binary" and "4bit", as I am unsure what is expected there
  • Similarly I did not add a single attribute to the component, should I ?

CHECKLIST

  • I have read and followed the library conventions1.
  • For packages, I followed IPC7351C (see details in library conventions)
  • For modified elements, I bumped their version number
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License2, allowing everyone to use and modify the content without any restrictions.

Footnotes

  1. Library Conventions: https://docs.librepcb.org/#libraryconventions

  2. CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@agagniere
Copy link
Author

agagniere commented Apr 13, 2024

Edits:

  • Found the dedicated 2-pins power pins symbol in the IC library, to use instead of the generic 1x2 connector
  • Call the component "And Quad" and not "Quad And", to align with the "OpAmp Quad"
  • The suffix of the power pins symbol is now "P" instead of "V", to align with the OpAmp

Preview:
Screenshot 2024-04-13 at 10 21 28

@agagniere
Copy link
Author

agagniere commented Apr 17, 2024

Edits:

  • Improved the 1-bit symbol, making it more compact
  • Hide pin names when they bring no information
  • Used the same symbol for 4-bits, with a bus notation
  • Added a 2-bits symbol
  • Fixed an incorrect reference

Preview:
Screenshot 2024-04-18 at 00 03 25
Screenshot 2024-04-18 at 00 06 05
Screenshot 2024-04-18 at 00 15 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant