Feature/cu 86dwa58wh/upgrade dockerfile serversideup #298
Conversation
sojeda
force-pushed
the
feature/cu-86dwa58wh/upgrade-dockerfile-serversideup
branch
from
0b0a667 to
80496f3
Compare
juancholightit
force-pushed
the
feature/cu-86dwa58wh/upgrade-dockerfile-serversideup
branch
from
80496f3 to
0b0a667
Compare
sojeda
force-pushed
the
feature/cu-86dwa58wh/upgrade-dockerfile-serversideup
branch
from
0b0a667 to
621c19d
Compare
.docker/scheduler-entrypoint.sh
Outdated
| #!/bin/sh | ||
| set -e | ||
|
|
||
| echo "Scheduler entrypoint script started." | ||
|
|
||
| while true; do | ||
| # Run the Laravel scheduler command. | ||
| # We use 'php -d memory_limit=-1' to ensure it doesn't run out of memory. | ||
| php -d memory_limit=-1 /var/www/html/artisan schedule:run | ||
|
|
||
| # Wait for 60 seconds before the next run. | ||
| sleep 60 | ||
| done No newline at end of file |
There was a problem hiding this comment.
This does not work due to the sleep not taking into account the duration of the schedule run, also, error handling is missing. Either run cron -f as exec argument for the container with a new crontab, or have schedule:run as the exec of the container and run a new instance of the container every 60 seconds via ecs native scheduler
https://laravel.com/docs/12.x/scheduling#running-the-scheduler
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/scheduling_tasks.html
| task-definition: task-definition.json | ||
| container-name: ${{ env.CONTAINER_NAME }} | ||
| image: ${{ env.REGISTRY_URL }}/${{ env.ECR_REPOSITORY }}:${{ env.IMAGE_TAG }} | ||
| container-name: sensifai |
| environment: develop | ||
| strategy: | ||
| matrix: | ||
| service: [api, scheduler] |
There was a problem hiding this comment.
Didnt have that present, will look into it, is there another side-service i should take into account?
Is it always needed or should be left as optional?
docker-compose.yml
Outdated
| image: 'postgres:16' | ||
| ports: | ||
| - '${FORWARD_DB_PORT:-5432}:5432' | ||
| - '${FORWARD_DB_PORT:-5555}:5432' |
There was a problem hiding this comment.
Had my local port in use and forgot about it, will set it back as default
…nd add UserRegistered notification for new users
…encies, and security improvements
…nd add UserRegistered notification for new users
…encies, and security improvements
sojeda
force-pushed
the
feature/cu-86dwa58wh/upgrade-dockerfile-serversideup
branch
from
ac01dc8 to
ca096ae
Compare
sojeda
force-pushed
the
12.x
branch
4 times, most recently
from
b4d3af9 to
4b5d162
Compare
sojeda
force-pushed
the
12.x
branch
3 times, most recently
from
f1b6b1f to
235a1b0
Compare
sojeda
force-pushed
the
12.x
branch
2 times, most recently
from
954520e to
7033547
Compare
4 participants
⚡ {0} - {1} ⚡
💻 What type of change is this?
{3}
⭐ Description
For more background, see ticket {1}[in-progress].
📷 Screenshots
Before
After
💬 Comments
✅ Checklist
To review