Skip to content

feat: Implement feature flag creation#43

Merged
inourbubble2 merged 9 commits intomainfrom
feature/flag-creation
Feb 24, 2025
Merged

feat: Implement feature flag creation#43
inourbubble2 merged 9 commits intomainfrom
feature/flag-creation

Conversation

@inourbubble2
Copy link
Contributor

@inourbubble2 inourbubble2 commented Feb 15, 2025

  • Implement feature flag creation and add unit tests
  • Add spring-security-test dependency
  • Configure JPA settings
  • Modify JsonConverter to throw IllegalArgumentException on failure
  • Disable OSIV)

I haven't run ktlint yet since there are many ongoing PRs in backend to avoid conflict with #39. It would be better to run ktlint all at once after this PR and #39 are merged.

Example response of the API:

HTTP/1.1 200 
Content-Type: application/json

{
  "status": "Success",
  "message": "Created flag successfully",
  "data": {
    "key": "user-limit",
    "status": true,
    "type": "number",
    "defaultValue": {
      "number": "10"
    },
    "description": "description",
    "variants": [
      {
        "number": "10"
      },
      {
        "free": "100"
      }
    ],
    "createdBy": "username",
    "updatedBy": "username",
    "createdAt": "2025-02-17T00:27:06.122584Z",
    "updatedAt": "2025-02-17T00:27:06.161132Z"
  }
}

@inourbubble2 inourbubble2 added the feature New Feature label Feb 15, 2025
@inourbubble2 inourbubble2 self-assigned this Feb 15, 2025
val status: Boolean,
@field:NotBlank(message = "Type is required.")
@field:Pattern(regexp = "^(number|boolean|string)$", message = "Type must be one of: number, boolean, string")
@field:Pattern(regexp = "(?i)^(number|boolean|string)$", message = "Type must be one of: number, boolean, string")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@eunhwa99 eunhwa99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@inourbubble2 inourbubble2 requested review from Yg-Hong and removed request for Yg-Hong February 21, 2025 11:42
@inourbubble2 inourbubble2 merged commit 9a4911d into main Feb 24, 2025
2 of 3 checks passed
@inourbubble2 inourbubble2 deleted the feature/flag-creation branch February 24, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants