Skip to content

Add support for resolving directories in /teamspace/lightning_storage #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2025

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Aug 22, 2025

What does this PR do ?

  • Add new directory resolver for /teamspace/lightning_storage/ paths
  • Support R2 cloud storage as source in data connections for /teamspace/lightning_storage/

Partially addresses #697

Copy link

gitguardian bot commented Aug 22, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5685611 Triggered Generic High Entropy Secret 21b8e01 tests/streaming/test_resolver.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bhimrazy bhimrazy changed the title feat(resolver): add support for resolving directories in /teamspace/lightning_storage Add support for resolving directories in /teamspace/lightning_storage Aug 22, 2025
@bhimrazy bhimrazy self-assigned this Aug 22, 2025
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84%. Comparing base (42cbc98) to head (da2c81c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #695   +/-   ##
===================================
  Coverage    84%    84%           
===================================
  Files        52     52           
  Lines      7081   7095   +14     
===================================
+ Hits       5958   5972   +14     
  Misses     1123   1123           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@bhimrazy bhimrazy marked this pull request as ready for review August 23, 2025 08:23
@bhimrazy bhimrazy enabled auto-merge (squash) August 23, 2025 08:24
@bhimrazy bhimrazy added the enhancement New feature or request label Aug 23, 2025
@bhimrazy bhimrazy merged commit 8e902df into Lightning-AI:main Aug 23, 2025
49 checks passed
@bhimrazy bhimrazy deleted the add-lightning_storage-folder branch August 23, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants