-
Notifications
You must be signed in to change notification settings - Fork 3.5k
check param is of nn.Parameter
type for pruning sanitization
#20783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up for an LSTM module, the bias parameter is a boolean which later stages of the pruning.
for more information, see https://pre-commit.ci
rittik9
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, can we also add a test for this??
7 tasks
Add unittests
nn.Parameter
type for pruning sanitization
Borda
approved these changes
Jun 18, 2025
Borda
reviewed
Jun 18, 2025
7 tasks
Update `test_pruning.py`
Borda
pushed a commit
that referenced
this pull request
Jun 19, 2025
* check param is of nn.Parameter type * Update test_pruning.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Rittik Panda <[email protected]> (cherry picked from commit cb1afbe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pl
Generic label for PyTorch Lightning package
waiting on author
Waiting on user action, correction, or update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pruning breaks because of non-
Parameter
types being passed through the pipeline. This came up for an LSTM module, the bias parameter is a boolean which breaks later stages of the pruning.What does this PR do?
I've only added a further check for the type of "prunable parameters" in the
sanitize_parameters_to_prune
function. I check if the parameter is of typenn.Parameter
so it has theto
method anddevice
property.Fixes #10835
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20783.org.readthedocs.build/en/20783/