Fix MLFlowLogger.save_dir Windows file URI handling #20988
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlebullGit
requested review from
williamFalcon,
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
rittik9
approved these changes
Jul 20, 2025
littlebullGit
changed the title
|
@lantiga @williamFalcon , @Borda @ethanwharris @tchaton @justusschock Let me know your comments. Any changes I need to get this PR approved? It has been 2 weeks. |
SkafteNicki
approved these changes
Aug 9, 2025
Borda
changed the title
littlebullGit
force-pushed
the
fix/20972-mlflow-logger-windows-uri-from-master
branch
from
41d41c0 to
c370a89
Compare
|
@littlebullGit this requires @williamFalcon only as he is the single code-owner for loggers |
littlebullGit
force-pushed
the
fix/20972-mlflow-logger-windows-uri-from-master
branch
from
196e27e to
d248b61
Compare
littlebullGit
force-pushed
the
fix/20972-mlflow-logger-windows-uri-from-master
branch
from
d0ef6b4 to
2025782
Compare
|
The failed check has nothing to do with the code fix. We can rerun the test once @williamFalcon reviewed the code. |
littlebullGit
force-pushed
the
fix/20972-mlflow-logger-windows-uri-from-master
branch
from
2025782 to
952e2ed
Compare
|
just rebased the PR |
- Replace simple string slicing with urllib.parse.urlparse and url2pathname - Properly handle Windows absolute file URIs (e.g., file:///C:/path) - Add comprehensive tests for various file URI formats - Fix malformed paths like ///C:/path becoming C:/path on Windows Fixes Lightning-AI#20972
- Handle both proper file URIs (file:///path) and legacy format (file:/path) - Proper URIs use urlparse/url2pathname for Windows compatibility - Legacy format used by constructor returns path as-is - Update tests to cover both formats and Windows behavior
littlebullGit
force-pushed
the
fix/20972-mlflow-logger-windows-uri-from-master
branch
from
6c52a05 to
de52cd6
Compare
|
build error did not seems related to my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MLFlowLogger.save_dir Windows file URI handling
What does this PR do?
Fixes #20972
This PR fixes a bug in
MLFlowLogger.save_dirwhere Windows absolute file URIs were being incorrectly parsed, resulting in malformed local paths that causedFileNotFoundErroron Windows systems.Problem:
When using [MLFlowLogger] with Windows absolute file URIs (e.g.,
file:///C:/Dev/example/mlruns), the [save_dir] property would return malformed paths like///C:/Dev/example/mlrunsinstead of the expectedC:/Dev/example/mlruns, causing file system operations to fail.Solution:
urllib.parse.urlparseandurllib.request.url2pathnamefile:///C:/path)///C:/pathbecomingC:/pathon WindowsChanges:
MLFlowLogger.save_dirproperty to use standard library URI parsing methods📚 Documentation preview 📚: https://pytorch-lightning--20988.org.readthedocs.build/en/20988/