-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add support for deepspeeds exclude_frozen_parameters
#21060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Borda
merged 14 commits into
Lightning-AI:master
from
SkafteNicki:deepspeed_exclude_frozen
Sep 2, 2025
Merged
Add support for deepspeeds exclude_frozen_parameters
#21060
Borda
merged 14 commits into
Lightning-AI:master
from
SkafteNicki:deepspeed_exclude_frozen
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21060 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 269 269
Lines 23574 23594 +20
=======================================
+ Hits 20561 20577 +16
- Misses 3013 3017 +4 |
Borda
approved these changes
Sep 2, 2025
the failign tests are without installed
|
Borda
pushed a commit
that referenced
this pull request
Sep 3, 2025
* add to deepspeed strategies * add testing * changelog * GLOO_SOCKET_IFNAME --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 5071a04)
lantiga
pushed a commit
that referenced
this pull request
Sep 5, 2025
* add to deepspeed strategies * add testing * changelog * GLOO_SOCKET_IFNAME --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 5071a04)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20949
Add new argument
exclude_frozen_parameters
toDeepSpeed
strategy that add support for saving checkpoints without frozen parameters. See the linked issue for explanation why this may be beneficial.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21060.org.readthedocs.build/en/21060/