[Refactor] Add vmmap-related calls [mmap / munmap / brk / sbrk] #142
+569
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
celinehoang177
commented
Mar 31, 2025
celinehoang177
commented
- Added implementation of mmap / munmap / brk / sbrk with new type conversion
Yaxuan-w
changed the title
Yaxuan-w
requested review from
JustinCappos,
ChinmayShringi,
qianxichen233 and
robinyuan1002
rennergade
reviewed
Jun 9, 2025
src/rawposix/src/fs_calls.rs
Outdated
| off_cageid: u64, | ||
| ) -> i32 { | ||
| // TODO: Check will perform in the below logic?? | ||
| println!("[mmap_syscall] selfcageid: {:?}, FD Cageid: {:?}", cageid, vfd_cageid); |
There was a problem hiding this comment.
is this supposed to still be here?
rennergade
reviewed
Jun 9, 2025
| /// | ||
| /// # Returns | ||
| /// * `u32` - Result of the `mmap` operation. See "man mmap" for details | ||
| pub fn mmap_syscall( |
There was a problem hiding this comment.
I see that we combined all of the mmap logic into one place here, which is a good first step, but it turns out pretty hard to read. It would be cool if we could separate this out with comments a bit or find places where it would make sense to internally functionize.
There was a problem hiding this comment.
I'm also thinking about priority here. Maybe we could open an issue to document this and optimize this later?
rennergade
reviewed
Jun 9, 2025
|
|
||
| // we are replacing munmap with mmap because we do not want to really deallocate the memory region | ||
| // we just want to set the prot of the memory region back to PROT_NONE | ||
| // Directly call libc::mmap to improve performance |
There was a problem hiding this comment.
does this improve performance?
There was a problem hiding this comment.
This is pasting from rawposix...
rennergade
requested changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.