[Refactor] Integrate 3i into Wasmtime runtime #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rennergade
reviewed
Jun 9, 2025
| @@ -68,17 +68,25 @@ impl LindCommonCtx { | |||
| // exit syscall | |||
| 30 => wasmtime_lind_multi_process::exit_syscall(caller, arg1 as i32), | |||
| // other syscalls goes into rawposix | |||
There was a problem hiding this comment.
either a long comment explaining the API or link to doc where its explained would be good
rennergade
reviewed
Jun 9, 2025
| @@ -43,6 +45,26 @@ fn parse_preloads(s: &str) -> Result<(String, PathBuf)> { | |||
| Ok((parts[0].into(), parts[1].into())) | |||
| } | |||
|
|
|||
| static VM_TABLE: Lazy<RwLock<Vec<Option<InstanceHandle>>>> = Lazy::new(|| { | |||
There was a problem hiding this comment.
comment what this is and what the functions below do
rennergade
reviewed
Jun 9, 2025
src/wasmtime/src/commands/run.rs
Outdated
| insert_ctx(current_pid as usize, grate_instancehandler.clone()); | ||
| } | ||
|
|
||
| let res = threei_test_func(current_pid, Box::new(move |call_ptr: u64, cageid: u64, arg1: u64, arg1cageid: u64, arg2: u64, arg2cageid: u64, arg3: u64, arg3cageid: u64, arg4: u64, arg4cageid: u64, arg5: u64, arg5cageid: u64, arg6: u64, arg6cageid: u64| -> i32 { |
There was a problem hiding this comment.
this is labeled test function, should this be part of the main codebase?
rennergade
reviewed
Jun 9, 2025
| @@ -186,6 +194,33 @@ pub fn add_to_linker< | |||
| }, | |||
| )?; | |||
|
|
|||
| // attach register_handler to wasmtime | |||
There was a problem hiding this comment.
id like more information in the comments on what these do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Wasmtime runtime to support 3i-based dynamic syscall interposition.
It introduces
(1) mechanisms for capturing and storing instance context (vmctx)
(2) resolving exported Wasm functions by name at runtime
(3) replacing all original
lind_syscall_apiin RawPOSIX dispatcher bymake_syscallin threei(4) supporting
copy_data_between_cagesandcopy_handler_tablein wasmtime sideNotes:
This can only be tested after all draft PR being merged.