Skip to content

Conversation

shinriyo
Copy link

I hope GetDoubleArray ()
And later. I create int[] version too

shinriyo added 2 commits May 23, 2014 18:55
we hope just get double[].
later I will add int[] too
It is useful
@lbv lbv mentioned this pull request Aug 17, 2014
@lbv
Copy link
Collaborator

lbv commented Aug 17, 2014

I like the idea, although I think it needs a little more work. For example, if we are going to implement Get methods for arrays of primitive types, it makes sense to provide them for all (GetIntArray, GetStringArray, ...).

Also, a couple of things I'd like to see along with the code changes to the library:

  • Unit tests. For example, what happens if the JSON string is something like [ 1, 2, "c", "d", 5 ]?
  • Examples of how this would be used, to add to the documentation.

But as I said, I like the main idea behind this, so I'll probably help you implement this when I find a little time. Thanks.

@devlead devlead changed the base branch from master to develop December 23, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants