Test and improve AIPI scanning - #1118
Merged
Merged
Conversation
FeTetra
approved these changes
Aug 29, 2026
Toastbrot236
added a commit
that referenced
this pull request
Aug 29, 2026
This is a followup PR which makes `ResourceValidationHelper` actually use `AipiService` if it's provided as a parameter and the validated asset is an image. It also fixes a bug where `GameAsset`s auto-imported by `ResourceValidationHelper` were not being added to the database. Additionally, this also marks the `AipiService` parameter on various endpoint methods as nullable to suppress useless warnings incase AIPI integration is disabled, and also suppresses a similar warning for `ResourceEndpoints.UploadAsset()`'s `type` route parameter, since it will be missing from ~99% of all game requests. This PR doesn't introduce any AIPI-related unit tests because that is blocked by #1118.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
AipiService. This allows us to write unit tests for AIPI integration.AipiServicenow announces the asset hash and the user when it's about to send an asset for scanning as an info log, and it now also logs if it's about to auto-restrict a user.AipiService.ScanAndHandleAsset()will now use a user passed by an additional parameter for logging and optional restriction. This is becauseGameAssets passed to the method can sometimes have a null uploader. Until now, the service just asserted that the uploader is not null, however, the user can sometimes be null in this case anyway, because we sometimes also scan assets on usage, instead of just on upload. Additionally, passing the user separately allows us to punish the user of the asset instead of its uploader if it's not an asset upload, but rather someone trying to use an existing asset as their level icon, for example.